-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger: remove PoW/faucet #1873
Conversation
self.submit_tx(tx_bytes); | ||
if !self.success() { | ||
resp.code = tendermint::abci::Code::Err(1337); // TODO: submit_tx should return the correct error code + message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@batconjurer I had to add this otherwise it kept trying to send the tx (cc @grarco )
apps/src/lib/client/signing.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file keeps coming back but we don't actually need it
core/src/types/storage.rs
Outdated
@@ -540,6 +540,18 @@ impl Key { | |||
self.segments.first() | |||
} | |||
|
|||
/// Return the owner of this subspace. None if empty or not an Address. | |||
pub fn owner(&self) -> Option<Address> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
6ac3fae
to
feae687
Compare
* origin/fraccaman/remove-pow: ledger: remove faucet, remove pow-for-fee
* origin/fraccaman/remove-pow: added changelog ledger: remove faucet, remove pow-for-fee
Describe your changes
pow-for-fee
featureIndicate on which release or other PRs this topic is based on
Checklist before merging to
draft